Skip to content

Print nicer messages for missing vs code #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

amanjpro
Copy link

@amanjpro amanjpro commented Jul 7, 2017

This will fix issue #2828

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@DarkDimius
Copy link
Contributor

@smarter could you please review it today so we can get it into next milestone?

@DarkDimius DarkDimius requested a review from smarter July 10, 2017 07:38
@smarter
Copy link
Member

smarter commented Jul 10, 2017

@DarkDimius Sure, but note that this is a change to sbt-dotty so it won't be part of the milestone anyway, we'll need to make a new release of sbt-dotty.

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is a nice improvement!

@smarter smarter merged commit 8a42e27 into scala:master Jul 10, 2017
@amanjpro amanjpro deleted the fix/issue-2828 branch July 10, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants